[dotnet][linker] Enable the sealer optimization #12009
Conversation
when (by default) * the interpreter is not enabled (since new code might subclass or override the members analyzed at build time) * building for release Reverts xamarin@c56b893 Fix xamarin#9573 Work-in-progress: * should be made easier to enable/disable (from user projects) * the above conditions should be the default (if nothing is specified)
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diff✅ API Diff (from PR only) (no change) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results5 tests failed, 107 tests passed.Failed tests
Pipeline on Agent XAMBOT-1100.BigSur' |
Even if possible (in metadata) there is no point in setting `final` on a method if we remove `virtual`. This match ILLink version of the sealer and makes the same test pass on both.
spouliot
changed the title
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diff✅ API Diff (from PR only) (no change) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results2 tests failed, 117 tests passed.Failed tests
Pipeline on Agent XAMBOT-1098.BigSur' |
features (like XML serialization) checks for `RuntimeFeature.IsDynamicCodeSupported` and that requires some types to be subclassed thru SRE
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diff✅ API Diff (from PR only) (no change) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results1 tests failed, 122 tests passed.Failed tests
Pipeline on Agent XAMBOT-1101.BigSur' |
|
Failure unrelated to PR -> https://github.com/xamarin/maccore/issues/2414 |
when (by default)
This has minimal impact on size (mono does not yet optimize this) but it ease the comparison of binaries between legacy and dotnet.
Reverts c56b893
Fix #9573